[BEAM-2365] Use the highest pickle protocol available. #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @vikkyrk |
|
jenkins: retest this please |
|
Changes Unknown when pulling accd42b on robertwb:pickle into ** on apache:master**. |
vikkyrk
reviewed
May 26, 2017
| @@ -365,7 +365,7 @@ def maybe_dill_dumps(o): | |||
| # We need to use the dill pickler for objects of certain custom classes, | |||
| # including, for example, ones that contain lambdas. | |||
| try: | |||
| return pickle.dumps(o) | |||
There was a problem hiding this comment.
Use https://docs.python.org/2/library/pickle.html#pickle.HIGHEST_PROTOCOL to be more clear with the intent?
|
LGTM |
|
Changes Unknown when pulling 45fb55a on robertwb:pickle into ** on apache:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify.<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.