Allow pr-bot to re-assign reviewers when stopped #31436
Conversation
|
R: @TheNeuralBit |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
scripts/ci/pr-bot/processPrUpdate.ts
Outdated
| @@ -94,6 +94,15 @@ async function processPrComment( | |||
| return; | |||
| } | |||
|
|
|||
| // Check to see if notifications have been stopped before processing further | |||
There was a problem hiding this comment.
Nit: Could we move this above the removeSlowReviewLabel check, and add an explanatory comment of why we still want to processCommand and not early exit sooner?
There was a problem hiding this comment.
Could we move this above the removeSlowReviewLabel check
Done
add an explanatory comment of why we still want to processCommand and not early exit sooner?
More comments added to code, but did you mean add a comment to the PR?
|
Apologies for slow reply.
This change will not alter the frequency in which PRBot will run, nor the actual number of reads of the PRState object (except for the cases where notifications are restarted!) Admittedly the reading/writing of PRstate is a bit inefficient - it could be read only once and then cached, and then the write deferred until the end of the PRBot run, but I didn't want to dive any deeper into this code! |
Fixes apache#31437 Enables the command `assign set of reviewers` to restart notifications if stopped
Yeah, I think its fine - I was thinking grabbing the comment body would incur an API call, but we actually already have that, so it should be fine |
|
Thanks! |
Fixes apache#31437 Enables the command `assign set of reviewers` to restart notifications if stopped
Fixes #31437
Enables the command
assign set of reviewersto restart notifications if stopped, for example after manual reviewer assignment.GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.