Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-1871] [BEAM-1019 ] Shade dependencies in sdks/coreShade dependencies in sdks/core #3004

Closed
wants to merge 3 commits into from
Closed

[BEAM-1871] [BEAM-1019 ] Shade dependencies in sdks/coreShade dependencies in sdks/core #3004

wants to merge 3 commits into from

Conversation

vikkyrk
Copy link
Contributor

@vikkyrk vikkyrk commented May 9, 2017 •
edited
Loading

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@vikkyrk
Copy link
Contributor Author

vikkyrk commented May 9, 2017

R: @davorbonaci

davorbonaci
davorbonaci approved these changes May 9, 2017
View reviewed changes
Copy link
Member

@davorbonaci davorbonaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

davorbonaci
davorbonaci approved these changes May 9, 2017
View reviewed changes
Copy link
Member

@davorbonaci davorbonaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikkyrk vikkyrk changed the title [BEAM-1871] [BEAM-1019 ] Cherry-pick: Shade dependencies in sdks/coreShade dependencies in sdks/core [BEAM-1871] [BEAM-1019 ] Shade dependencies in sdks/coreShade dependencies in sdks/core May 10, 2017
@vikkyrk
Copy link
Contributor Author

vikkyrk commented May 10, 2017

R: @kennknowles @lukecwik

@asfgit asfgit closed this in 78a4b8e May 10, 2017
@vikkyrk vikkyrk deleted the shade branch May 10, 2017 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davorbonaci davorbonaci davorbonaci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vikkyrk @davorbonaci