[BEAM-806] Use filtering for the version of the reference test project #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Merged. (I had to do a rebase and did a super minor clean-up.) |
asfgit
pushed a commit
that referenced
this pull request
May 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With BEAM-2093 the archetypes almos could be released with maven commands without manual version adjustment.
The missing part is in the starter archetype where an integration test compares a predefined project with the generated one. The prefefined reference project also should be filtered to always use the current version.
sdks/java/maven-archetypes/starter/src/test/resources/projects/basic/reference/pom.xml
To reproduce the problem (without this patch) do
mvn versions:set -DnewVersion=0.8.0-SNAPSHOT, and try to build the project.