Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1950] Add missing 'static' keyword to MicrobatchSource#initReaderCache #2514

Closed

Conversation

aviemzur
Copy link
Member

@aviemzur aviemzur commented Apr 12, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@aviemzur
Copy link
Member Author

R: @staslev

@staslev
Copy link
Contributor

staslev commented Apr 12, 2017

LGTM (pending tests).

@asfbot
Copy link

asfbot commented Apr 12, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/1608/
--none--

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 70.576% when pulling 5751c0d on aviemzur:fix-microbatchsource-readercache-lock into 571631a on apache:master.

@asfbot
Copy link

asfbot commented Apr 12, 2017

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 70.576% when pulling 5751c0d on aviemzur:fix-microbatchsource-readercache-lock into 571631a on apache:master.

@asfbot
Copy link

asfbot commented Apr 12, 2017

@asfbot
Copy link

asfbot commented Apr 12, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/1611/
--none--

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 70.096% when pulling 5751c0d on aviemzur:fix-microbatchsource-readercache-lock into 571631a on apache:master.

@asfbot
Copy link

asfbot commented Apr 13, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9487/
--none--

@asfgit asfgit closed this in 21a2b96 Apr 13, 2017
@aviemzur aviemzur deleted the fix-microbatchsource-readercache-lock branch April 13, 2017 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants