Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the isStreaming PipelineOption #2315

Closed
wants to merge 2 commits into from

Conversation

tgroh
Copy link
Member

@tgroh tgroh commented Mar 24, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

This is automatically inferred when necessary in all existing runners.
Users should not need to set it unless they wish to force an alternative
execution environment in a runner that respects this flag while running
a Bounded Pipeline.

This is automatically inferred when necessary in all existing runners.
Users should not need to set it unless they wish to force an alternative
execution environment in a runner that respects this flag while running
a Bounded Pipeline.
@tgroh
Copy link
Member Author

tgroh commented Mar 24, 2017

Any of:
@dhalperi @francesperry @davorbonaci @jkff

Copy link
Member

@davorbonaci davorbonaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for self merge.

@@ -25,7 +25,9 @@
/**
* Set to true if running a streaming pipeline.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix javadoc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@asfgit asfgit closed this in 5903e69 Mar 24, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 70.089% when pulling 2c94c4f on tgroh:hide_isStreaming into 5c2da7d on apache:master.

@asfbot
Copy link

asfbot commented Mar 24, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8767/
--none--

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 70.105% when pulling 2c94c4f on tgroh:hide_isStreaming into 5c2da7d on apache:master.

@asfbot
Copy link

asfbot commented Mar 24, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8768/
--none--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants