Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused field in FlinkRunner #2310

Closed
wants to merge 1 commit into from
Closed

Remove unused field in FlinkRunner #2310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions runners/flink/runner/src/main/java/org/apache/beam/runners/flink/FlinkRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
package org.apache.beam.runners.flink;

import com.google.common.base.Joiner;
import com.google.common.collect.ImmutableMap;
import java.io.File;
import java.net.URISyntaxException;
import java.net.URL;
Expand All @@ -36,7 +35,6 @@
import org.apache.beam.sdk.options.PipelineOptionsValidator;
import org.apache.beam.sdk.runners.PipelineRunner;
import org.apache.beam.sdk.runners.TransformHierarchy;
import org.apache.beam.sdk.transforms.Combine;
import org.apache.beam.sdk.transforms.PTransform;
import org.apache.beam.sdk.transforms.View;
import org.apache.beam.sdk.values.PValue;
Expand All @@ -59,9 +57,6 @@ public class FlinkRunner extends PipelineRunner<PipelineResult> {
*/
private final FlinkPipelineOptions options;

/** Custom transforms implementations. */
private final Map<Class<?>, Class<?>> overrides;

/**
* Construct a runner from the provided options.
*
Expand Down Expand Up @@ -102,19 +97,6 @@ public static FlinkRunner fromOptions(PipelineOptions options) {
private FlinkRunner(FlinkPipelineOptions options) {
this.options = options;
this.ptransformViewsWithNonDeterministicKeyCoders = new HashSet<>();

ImmutableMap.Builder<Class<?>, Class<?>> builder = ImmutableMap.<Class<?>, Class<?>>builder();
if (options.isStreaming()) {
builder.put(Combine.GloballyAsSingletonView.class,
FlinkStreamingViewOverrides.StreamingCombineGloballyAsSingletonView.class);
builder.put(View.AsMap.class, FlinkStreamingViewOverrides.StreamingViewAsMap.class);
builder.put(View.AsMultimap.class, FlinkStreamingViewOverrides.StreamingViewAsMultimap.class);
builder.put(View.AsSingleton.class,
FlinkStreamingViewOverrides.StreamingViewAsSingleton.class);
builder.put(View.AsList.class, FlinkStreamingViewOverrides.StreamingViewAsList.class);
builder.put(View.AsIterable.class, FlinkStreamingViewOverrides.StreamingViewAsIterable.class);
}
overrides = builder.build();
}

@Override
Expand Down