Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-115] Make Canonical ViewFns Public #2309

Closed
wants to merge 1 commit into from

Conversation

tgroh
Copy link
Member

@tgroh tgroh commented Mar 23, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

Mark all of the ViewFns as both deprecated and experimental. These fns
will all be removed once Runners have multimap support, and are not
suitable for users to use explicitly.

Mark all of the ViewFns as both deprecated and experimental. These fns
will all be removed once Runners have multimap support, and are not
suitable for users to use explicitly.
@tgroh
Copy link
Member Author

tgroh commented Mar 23, 2017

R: @kennknowles

@kennknowles
Copy link
Member

LGTM

@asfbot
Copy link

asfbot commented Mar 23, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8745/

Build result: FAILURE

[...truncated 2.47 MB...] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 moreCaused by: java.lang.RuntimeException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?Command was /bin/sh -c cd /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/examples/java && /usr/local/asfpackages/java/jdk1.8.0_121/jre/bin/java '-javaagent:/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/.repository/org/jacoco/org.jacoco.agent/0.7.8/org.jacoco.agent-0.7.8-runtime.jar=destfile=/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/examples/java/target/jacoco.exec,excludes=**/AutoValue_*.class,dumponexit=true,output=file' org.apache.maven.surefire.booter.ForkedBooter /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/examples/java/target/surefire/surefire4219303619602886257tmp /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/examples/java/target/surefire/surefire_13820430081948024530tmp at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:590) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:460) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:229) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:201) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1026) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:862) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:755) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) ... 32 more2017-03-23T23:13:37.875 [ERROR] 2017-03-23T23:13:37.876 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-03-23T23:13:37.876 [ERROR] 2017-03-23T23:13:37.876 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-03-23T23:13:37.876 [ERROR] [Help 1] http:https://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException2017-03-23T23:13:37.876 [ERROR] 2017-03-23T23:13:37.876 [ERROR] After correcting the problems, you can resume the build with the command2017-03-23T23:13:37.876 [ERROR] mvn -rf :beam-examples-javachannel stoppedSetting status of b3ea5b2 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8745/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@tgroh
Copy link
Member Author

tgroh commented Mar 24, 2017

retest this please

@asfbot
Copy link

asfbot commented Mar 24, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8751/
--none--

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b3ea5b2 on tgroh:public_view_fns into ** on apache:master**.

@asfgit asfgit closed this in 14aba81 Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants