[BEAM-1796] Make testShiftTimestampInvalid NeedsRunner instead of ROS

[tgroh]

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

• Make sure the PR title is formatted like:
  [BEAM-<Jira issue #>] Description of pull request
• Make sure tests pass via mvn clean verify. (Even better, enable
  Travis-CI on your fork and ensure the whole test matrix passes).
• Replace <Jira issue #> in the title with the actual Jira issue
  number, if there is one.
• If this contribution is large, please file an Apache
  Individual Contributor License Agreement.

---

Currently broken in Apex. I'm investigating.

@jkff @tweise

[tgroh]

Example Break: https://builds.apache.org/job/beam_PostCommit_Java_RunnableOnService_Apex/842/changes

[tgroh]

Run Apex RunnableOnService

[jkff]

Can you clarify what effect you're intending to achieve by changing it from ROS to NR?

[coveralls]

Coverage remained the same at 70.159% when pulling 109a5ba on tgroh:apex-shift-timestamp-invalid into ddc7595 on apache:master.

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8728/
--none--

[tgroh]

Changing to RunnableOnService will cause it to not be picked up by the Apex RunnableOnService execution. That will stop it from breaking in Apex until the actual fix goes in.

[tgroh]

Specifically, the Apex RunnableOnService category will not execute any NeedsRunner tests, as it's not configured to pick them up; the test needs to be marked as NeedsRunner or ignored as the SDK doesn't have the proper classes to execute the test in the right context (with a Pipeline Runner)

[jkff]

LGTM modulo Apex ROS tests passing. Please also file a JIRA about this breakage and tag the PR with it.

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PostCommit_Java_RunnableOnService_Apex/845/
--none--

[tgroh]

Filed https://issues.apache.org/jira/browse/BEAM-1796