[Tour Of Beam][backend] integration tests and GA workflow #23032

eantyshev · 2022-09-05T16:28:16Z

addresses #23005

Basic integration tests, GitHub action-wrapped, and a bit of a boilerplate to run it locally
Essentially an acceptance test.

Setup and run Datastore emulator in background process
Compile Cloud Functions and run them in background
Execute CD step for samples/learning-content
Run integration tests that call CFs via HTTP client. Compare responses with those from samples/api.
Datastore emulator generates indexes while the queries are executed. Compare it with VCS version. We will use it in future Cloud Deployment workflow.

Example workflow run:
https://github.com/akvelon/beam/runs/8192798498

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Choose reviewer(s) and mention them in a comment (R: @username).
Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

github-actions · 2022-09-06T09:05:46Z

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

olehborysevych · 2022-09-08T09:59:06Z

lgtm

olehborysevych · 2022-09-08T10:01:51Z

R: @damccorm

github-actions · 2022-09-08T10:03:02Z

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

damccorm

This generally looks good to me, left a few small comments

damccorm · 2022-09-08T12:48:03Z

.github/workflows/tour_of_beam_backend.yml

+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}'
+ cancel-in-progress: true


I wasn't familiar with this feature - neat!

FYI, I added #23089 because I think we should be doing this more broadly - thanks for introducing it to the repo 😄

damccorm · 2022-09-08T12:52:30Z

.github/workflows/tour_of_beam_backend_integration.yml

+ - uses: actions/checkout@v3
+ - uses: actions/setup-go@v3
+ with:
+ go-version: '1.16'


Minor: Could we add a comment explaining we're pinning to 1.16 because Google Cloud Functions don't support higher versions (ideally here and in tour_of_beam_backend.yml)? That way we avoid a well meaning contributor (or dependabot) bumping the version.

learning/tour-of-beam/backend/integration_tests/client.go

learning/tour-of-beam/backend/integration_tests/function_test.go

damccorm · 2022-09-08T13:04:36Z

learning/tour-of-beam/backend/internal/storage/image/Dockerfile

@@ -24,7 +24,7 @@ FROM google/cloud-sdk:$GCLOUD_SDK_VERSION
 VOLUME /opt/data

 # RUN mkdir -p /opt/data/WEB-INF
-COPY index.yaml /opt/data/WEB-INF/index.yaml
+# COPY index.yaml /opt/data/WEB-INF/index.yaml


Should we just remove this entirely? Why did we end up moving this?

This was my initial idea of how to validate Datastore indexes: by copying it to the Datastore emulator container
But that actually doesn't work: emulator updates WEB-INF/index.yaml when it executes the query which requires a composite index.
So, in this PR we switch to comparing the generated index.yaml with our VCS version after the tests
Assuming integration tests covered every possible Datastore query, it produces an index that must work when deployed to Cloud

The line has to be removed, I overlooked that I only commented it

Co-authored-by: Danny McCormick <[email protected]>

damccorm

LGTM - thanks!

* tests * WF * chdir * order * nit * fix * nit * concurrency * integration_go * tags * cache_go * nit * nit * rat * datadir * env * env * reduce fun * removing unicode character * Update learning/tour-of-beam/backend/integration_tests/client.go Co-authored-by: Danny McCormick <[email protected]> * Update learning/tour-of-beam/backend/integration_tests/function_test.go Co-authored-by: Danny McCormick <[email protected]> * review * nit Co-authored-by: oborysevych <[email protected]> Co-authored-by: Danny McCormick <[email protected]>

eantyshev added 13 commits September 5, 2022 12:14

tests

c5e2238

WF

15c79a1

chdir

52ebb6d

order

3fd1a2c

nit

260637f

fix

9da4106

nit

f825ce0

concurrency

65d61d2

integration_go

ff1d871

tags

6176faa

cache_go

2890a84

nit

188d6ad

nit

6bc152f

github-actions bot added build learning labels Sep 5, 2022

rat

dc19236

eantyshev marked this pull request as ready for review September 6, 2022 08:46

olehborysevych added the tour-of-beam label Sep 6, 2022

datadir

8f65c02

github-actions bot added the Next Action: Reviewers label Sep 6, 2022

eantyshev and others added 4 commits September 6, 2022 12:31

env

0d0818f

env

7f6f48b

reduce fun

c72d26e

removing unicode character

1956315

damccorm reviewed Sep 8, 2022

View reviewed changes

Update learning/tour-of-beam/backend/integration_tests/client.go

e867eb9

Co-authored-by: Danny McCormick <[email protected]>

eantyshev and others added 3 commits September 8, 2022 17:13

Update learning/tour-of-beam/backend/integration_tests/function_test.go

10aa920

Co-authored-by: Danny McCormick <[email protected]>

review

1da6eb9

nit

bf5c10f

damccorm mentioned this pull request Sep 8, 2022

[Feature Request]: Auto-cancel old Actions Runs #23089

Closed

damccorm approved these changes Sep 8, 2022

View reviewed changes

damccorm merged commit 9efa378 into apache:master Sep 8, 2022

eantyshev deleted the tob_integration_tests branch September 12, 2022 10:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tour Of Beam][backend] integration tests and GA workflow #23032

[Tour Of Beam][backend] integration tests and GA workflow #23032

eantyshev commented Sep 5, 2022 •

edited

Loading

github-actions bot commented Sep 6, 2022

olehborysevych commented Sep 8, 2022

olehborysevych commented Sep 8, 2022

github-actions bot commented Sep 8, 2022

damccorm left a comment

damccorm Sep 8, 2022

damccorm Sep 8, 2022

damccorm Sep 8, 2022

damccorm Sep 8, 2022

eantyshev Sep 8, 2022 •

edited

Loading

damccorm left a comment

[Tour Of Beam][backend] integration tests and GA workflow #23032

[Tour Of Beam][backend] integration tests and GA workflow #23032

Conversation

eantyshev commented Sep 5, 2022 • edited Loading

GitHub Actions Tests Status (on master branch)

github-actions bot commented Sep 6, 2022

olehborysevych commented Sep 8, 2022

olehborysevych commented Sep 8, 2022

github-actions bot commented Sep 8, 2022

damccorm left a comment

Choose a reason for hiding this comment

damccorm Sep 8, 2022

Choose a reason for hiding this comment

damccorm Sep 8, 2022

Choose a reason for hiding this comment

damccorm Sep 8, 2022

Choose a reason for hiding this comment

damccorm Sep 8, 2022

Choose a reason for hiding this comment

eantyshev Sep 8, 2022 • edited Loading

Choose a reason for hiding this comment

damccorm left a comment

Choose a reason for hiding this comment

eantyshev commented Sep 5, 2022 •

edited

Loading

eantyshev Sep 8, 2022 •

edited

Loading