[BEAM-1771] Clean up dataflow/google references/URLs in examples #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
asfgit
pushed a commit
that referenced
this pull request
Mar 23, 2017
aromanenko-dev
added a commit
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @aaltay @davorbonaci
In examples/java/README, I separated and created a section for each runner so it's easy for other runners to add their commands also. Please verify I didn't mess up the command lines when doing that, as I'm not familiar with the bundling. Long term, I am wondering if most of the README content would be better off in the Word Count walkthrough on the website? as it's similar to what's there already, and then we can use tabs for Java/Python and the different runners. It'd also mean the user no longer needs to go back and forth between the walkthrough and the README.