[BEAM-1746] Include LICENSE and NOTICE in python dist files

[aaltay]

R: @davorbonaci

Davor, is this the right way to approach the problem? (I would like to copy files before packaging and delete copied files post packaging.)

[davorbonaci]

I'd try to avoid this approach.

I'd attempt to do this with an assembly plugin at the top-level, just like the project-wide source release is built. We just specify there to take LICENSE & NOTICE + all stuff in the Python directory.

[davorbonaci]

This is much better served by configuring the maven-clean-plugin directly, as opposed to creating a new execution to delete a file.

[davorbonaci]

I wouldn't do this -- reaching outside the current context generally breaks things.

[coveralls]

Coverage decreased (-0.003%) to 70.177% when pulling 8ecaa46 on aaltay:licnot into cc12fd3 on apache:master.

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8402/
--none--

[coveralls]

Coverage decreased (-0.01%) to 70.283% when pulling 0b16ceb on aaltay:licnot into b47fd52 on apache:master.

[aaltay]

@davor updated the PR, PTAL.

This changes moves the copying piece to the root pom.xml. At root level these two files needed for Python packaging (LICENSE and NOTICE) pushed down to the right folder.

One may ask, why are we not packaging python at root instead of pushing down these files. The reason is we need to execute setup.py for packaging. The resulting package could only contain files that exist in the same sub-directory tree as the location of setup.py. And building the python package at root would require copying the whole sdks/python path to root.

Another question would be, what happens if mvn is invoked directly as sdks/python directory. In this case, packaging will succeed however resulting artifacts would not have the necessary files. This should not be a problem since our release procedure requires running mvn at root for packaging all needed artifacts.

[davorbonaci]

LGTM