-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-8676] Upgrade gax-java 1.60.0 and grpc 1.32.2 #13151
Conversation
#13075 is working on using the GCP libraries BOM within Beam to manage deps. It would be preferable if that change made it in first and we updated the libraries BOM version to one containing grpc 1.32.2 instead of doing these one off changes. |
@lukecwik Oh having the bom would be nicer. As long as I can get this upgrade in Beam 2.26, I'm fine with both approaches. Do you think it will happen in Nov 4? |
I should be able to get in the BOM changes before Nov 4th. Do you know when the libraries bom update will be released? |
12.1.0 has already been released containing the updated gRPC instance. |
We can merge this while we are getting ready for the change to the BOM. |
Run Java PreCommit |
Run Python_PVR_Flink PreCommit |
Run Portable_Python PreCommit |
Some of the failures looked potentially real, in tests that have not flaked previously. |
I guess There are two tests failing. I guess this is coming from protobuf upgrading to 3.12 (from 3.11.1) Because I don't think protobuf introduced actual breaking changes so I took a look at these test code,
The error message is like below.
From the code & output reading, it might be caused by using string comparison to compare two objects but chances are that two strings are not normalized, which could cause them to fail. (it's my wild guess) @alexvanboxel, @reuvenlax |
Note that the Python tests are Python-on-Flink so they do touch a number of Beam libraries. I think you are probably right that they are not actually affected, but do not let the name fool you. |
Agree with your assessment. These tests are written in a fragile way. The strings should not be normalized, but just test the equality directly in a robust way. |
@kennknowles I addressed the issue of the test. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for hardening the test! The results are green and look good. The commit history is clean. Thanks a bunch!
gRPC 1.32.2 has two important changes;
R: @suztomo @lukecwik
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.