Refactor time functions test out of giant ZetaSqlDialectSpecTest #12219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Java_Examples_Dataflow_Java11 PreCommit |
|
Run Java PreCommit |
ibzib
reviewed
Jul 10, 2020
...tasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlTimeFunctionsTest.java
Outdated
Show resolved
Hide resolved
...s/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/StreamingSqlTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor test code for DATE/TIME/DATETIME/TIMESTAMP functions out of
ZetaSqlDialectSpecTestsince it has grown too big. We can also do this for other categories of functions (e.g String/Bytes functions) in the future.Also cleaned up the code a bit. No functional change, other than turning on previously ignored test
testTimeAddWithParameterswhich is now working.r: @apilloud @ibzib (Consider factoring out UDF tests as well? I think technically they are an extension to ZetaSQL dialect, similar to
StreamingSqlTest)cc: @ZijieSong946
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.