[BEAM-10444] Simpler PAssert for simpler cases. #12218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @ibzib |
ibzib
reviewed
Jul 10, 2020
sdks/java/core/src/main/java/org/apache/beam/sdk/testing/PAssert.java
Outdated
Show resolved
Hide resolved
| .and(actual) | ||
| .apply(Flatten.pCollections()) | ||
| .apply( | ||
| // Default end-of-window trigger dissallowed for unbounded PCollections. |
There was a problem hiding this comment.
Why does this only apply to unbounded PCollections? It looks like the existing translation removes triggers for both bounded and unbounded.
There was a problem hiding this comment.
Due to the if condition, the triggering (and windowing) is already the default, which is fine for bounded but not for unbounded. (I opted to leave it this way for bounded so that you don't have to know about the never.ever trigger to do bounded PAsserts.)
…rt.java Co-authored-by: Kyle Weaver <[email protected]>
yirutang
pushed a commit
to yirutang/beam
that referenced
this pull request
Jul 23, 2020
If we don't have to worry about complicated triggering semantics we can generate a much simpler pipeline. This is particularly useful for bootstrapping runners so that we can run subsets of the validates runner test suite requiring support of only the most basic primitives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.