[BEAM-9629] Fix several connection leak issues. #12209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make the default max connections to be unlimited. This mirrors the 2.17 and earlier behavior since we used to create one DataSource per execution thread (and hence one connection). * Move connection fetching to @ProcessElement to not hold a connection for empty bundles. * Make sure that finalize() closes the connection so that it is returned to the pool if the bundle fails.
iemejia
approved these changes
Jul 10, 2020
| * <p>By default, the provided function requests a DataSource per execution thread. In some | ||
| * circumstances this can quickly overwhelm the database by requesting too many connections. In that | ||
| * case you should look into sharing a single instance of a {@link PoolingDataSource} across all the | ||
| * execution threads. |
There was a problem hiding this comment.
Since this is a recurrent issue for users I am wondering if It would probably be good to add a snippet of how to achieve this (maybe in a subsequent PR since it is not exactly related).
TheNeuralBit
approved these changes
Jul 10, 2020
yirutang
pushed a commit
to yirutang/beam
that referenced
this pull request
Jul 23, 2020
* Make the default max connections to be unlimited. This mirrors the 2.17 and earlier behavior since we used to create one DataSource per execution thread (and hence one connection). * Move connection fetching to @ProcessElement to not hold a connection for empty bundles. * Make sure that finalize() closes the connection so that it is returned to the pool if the bundle fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.