-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-9679] Add Partition task to Core Transform katas #11979
[BEAM-9679] Add Partition task to Core Transform katas #11979
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good To Me (LGTM)
@henryken should I go ahead and update the Stepik course? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am surprised to see a 859 line PR for what amounts to a 20-line example accompanied by about 20 lines of docs. Is there some way to have less auto-generated code checked in? |
I can't speak to the Kata generated code, but the go.mod and go.sum files are strongly recommended to be submitted as is to ensure full transitive dependency of the right and correct package versions are included. They aren't intended for human consumption for the most part. |
IntelliJ Edu autogenerated a go.mod in each lesson so that they are independently runnable when the course files are provided to the user. I had been thinking of deviating from IntelliJ Edu's method and instead just having one go.mod in learning/katas/go. Should I start another pull request if I'm successful at this? |
The Kata generated metadata files are important and only contain few lines of code. What I understand is that each lesson is run like a mini Go project/module. |
@henryken / @lostluck I've started work on consolidating the module by beginning work at this branch: master...damondouglas:BEAM-10428-single-module-kata-go Essentially the final goal is to make one go.mod at the root of learning/katas/go. So far I've only changed the Hello Beam section so you can preview what I intend for the rest. Would it make sense to start a PR for this branch without the intent to merge initially but until the entire learning/katas/go is refactored? |
That works fine. Given how mechanical the change is, it wouldn't be unreasonable to do the change all at once in one PR. However, I do recommend doing all the directory renames in separate commits from the deleting the old mods so that we can check the relatively smaller changes on a per commit basis (rather than just all at once). Won't matter to the final merge, since it will get squashed, but it will make it easier to review. |
This pull requests adds a Partition lesson to the Go SDK katas. I would like to request the following reviewers:
(R: @lostluck )
(R: @henryken )
If accepted by both reviewers, please wait until the Stepik course is updated before finally merging this PR.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.