[BEAM-10204] @Ignore: re-enable LIKE operator related unit tests. #11933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run SQL PreCommit |
tysonjh
reviewed
Jun 5, 2020
| @@ -837,7 +834,6 @@ public void testLikeAllowsEscapingBackslash() { | |||
| } | |||
|
|
|||
| @Test | |||
| @Ignore("Currently non UTF-8 values are coerced to UTF-8") | |||
| public void testThrowsErrorForNonUTF8() { | |||
There was a problem hiding this comment.
This test name doesn't seem correct after these changes. What is it testing now? What about the previous assertions on throwing an exception for invalid utf8?
There was a problem hiding this comment.
This is a good point. I will choose to remove this test.
I tried to dig into ZetaSQL's documentation and internal tests suite, there was no clear explanation how to deal with nonUTF8 chars by LIKE operator (there are code-generated nonUTF8 test cases, but they don't have clear comments to demonstrate their purpose). So I will leave this part to be tested by internal test suite.
tysonjh
approved these changes
Jun 5, 2020
yirutang
pushed a commit
to yirutang/beam
that referenced
this pull request
Jul 23, 2020
…ache#11933) * [BEAM-10204] @ignore: re-enable LIKE operator related unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/BEAM-10204
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.