Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-10176] Support STRUCT, FLOAT64, INT64 BigQuery types #11923

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

chunyang
Copy link
Contributor

@chunyang chunyang commented Jun 4, 2020

Support STRUCT, FLOAT64, INT64 BigQuery types in BIgQuery to Avro schema conversion.

We already support RECORD, FLOAT, and INTEGER, which are aliases of the three types being added.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

Support STRUCT, FLOAT64, INT64 BigQuery types in WriteToBigQuery with
Avro temp file format.
@chunyang
Copy link
Contributor Author

chunyang commented Jun 4, 2020

R: @pabloem

@pabloem
Copy link
Member

pabloem commented Jun 5, 2020

retest this please

@pabloem
Copy link
Member

pabloem commented Jun 6, 2020

Run Python 3.7 PostCommit

3 similar comments
@pabloem
Copy link
Member

pabloem commented Jun 6, 2020

Run Python 3.7 PostCommit

@pabloem
Copy link
Member

pabloem commented Jun 8, 2020

Run Python 3.7 PostCommit

@pabloem
Copy link
Member

pabloem commented Jun 9, 2020

Run Python 3.7 PostCommit

@chunyang
Copy link
Contributor Author

chunyang commented Jun 9, 2020

I think there's an attempt to fix the failures in #11946? I will wait for that and rebase.

@kamilwu
Copy link
Contributor

kamilwu commented Jun 9, 2020

I think there's an attempt to fix the failures in #11946?

You're right. The fix's been merged, everything should be fine now.

@kamilwu
Copy link
Contributor

kamilwu commented Jun 9, 2020

Run Python 3.7 PostCommit

@pabloem pabloem merged commit 564cef0 into apache:master Jun 9, 2020
@pabloem
Copy link
Member

pabloem commented Jun 9, 2020

thanks @chunyang

@chunyang chunyang deleted the cyang/more-type-names branch September 27, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants