Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor formatting updates. #11920

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Minor formatting updates. #11920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Minor formatting updates. 
- Chain constructors instead of assigning directly;
- Typo fixes.
  • Loading branch information
@lastomato
lastomato committed Jun 4, 2020
commit 74290599f0c430e6d4506e3f7b371c3a7e321577
10 changes: 2 additions & 8 deletions .../io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
* <h3>Reading</h3>
*
* <p>FHIR resources can be read with {@link FhirIO.Read}, which supports use cases where you have a
* ${@link PCollection} of message IDS. This is appropriate for reading the Fhir notifications from
* ${@link PCollection} of message IDs. This is appropriate for reading the Fhir notifications from
* a Pub/Sub subscription with {@link PubsubIO#readStrings()} or in cases where you have a manually
* prepared list of messages that you need to process (e.g. in a text file read with {@link
* org.apache.beam.sdk.io.TextIO}*) .
Expand Down Expand Up @@ -741,13 +741,7 @@ public static class Import extends Write {
ValueProvider<String> fhirStore,
ValueProvider<String> deadLetterGcsPath,
@Nullable ContentStructure contentStructure) {
this.fhirStore = fhirStore;
this.deadLetterGcsPath = deadLetterGcsPath;
if (contentStructure == null) {
this.contentStructure = ContentStructure.CONTENT_STRUCTURE_UNSPECIFIED;
} else {
this.contentStructure = contentStructure;
}
this(fhirStore, null, deadLetterGcsPath, contentStructure);
}
/**
* Instantiates a new Import.
Expand Down
10 changes: 2 additions & 8 deletions ...platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HttpHealthcareApiClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,12 +548,7 @@ public static class HL7v2MessagePages implements Iterable<List<HL7v2Message>> {
String hl7v2Store,
@Nullable Instant start,
@Nullable Instant end) {
this.client = client;
this.hl7v2Store = hl7v2Store;
this.filter = null;
this.orderBy = null;
this.start = start;
this.end = end;
this(client, hl7v2Store, start, end, null, null);
}

/**
Expand Down Expand Up @@ -660,9 +655,8 @@ public boolean hasNext() throws NoSuchElementException {
List<Message> msgs = response.getHl7V2Messages();
if (msgs == null) {
return false;
} else {
return !msgs.isEmpty();
}
return !msgs.isEmpty();
} catch (IOException e) {
throw new NoSuchElementException(
String.format(
Expand Down