Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-10179] Clean-up URNJavaDoFn workaround in Go SDK. #11899

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

lukecwik
Copy link
Member

@lukecwik lukecwik commented Jun 2, 2020

Now that the SDK has migrated to use the Dataflow runner v2, this is no longer required.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

Now that the SDK has migrated to use the Dataflow runner v2, this is no longer required.
@probot-autolabeler probot-autolabeler bot added the go label Jun 2, 2020
@lukecwik
Copy link
Member Author

lukecwik commented Jun 2, 2020

R: @lostluck @youngoli

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense now that this version of the code uses runnerV2 on Dataflow.

@lostluck
Copy link
Contributor

lostluck commented Jun 2, 2020

Run Go PostCommit

@lukecwik lukecwik merged commit 10f6473 into apache:master Jun 2, 2020
yirutang pushed a commit to yirutang/beam that referenced this pull request Jul 23, 2020
Now that the SDK has migrated to use the Dataflow runner v2, this is no longer required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants