Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-10066] Add support for ValueProviders in RedisConnectionConfiguration #11799

Closed
wants to merge 2 commits into from
Closed

[BEAM-10066] Add support for ValueProviders in RedisConnectionConfiguration #11799

wants to merge 2 commits into from

Conversation

naipath
Copy link
Contributor

@naipath naipath commented May 22, 2020

This pull request adds support for ValueProvider in RedisConnectionConfiguration.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@naipath naipath changed the title Added support for the ValueProvider for RedisConnectionConfiguration [BEAM-10066] Added support for the ValueProvider for RedisConnectionConfiguration May 22, 2020
@naipath naipath changed the title [BEAM-10066] Added support for the ValueProvider for RedisConnectionConfiguration [BEAM-10066] Added support for ValueProvider in RedisConnectionConfiguration May 22, 2020
@naipath
Copy link
Contributor Author

naipath commented May 22, 2020

R: @jbonofre

@iemejia
Copy link
Member

iemejia commented May 26, 2020

retest this please

@iemejia
Copy link
Member

iemejia commented May 27, 2020

@naipath Can you please run ./gradlew :sdks:java:io:redis:check spotlessApply and update the PR, can you also please change the commit title to include the ticket: "[BEAM-10066] Added support for ValueProvider in RedisConnectionConfiguration" Thanks

@naipath
Copy link
Contributor Author

naipath commented Jun 5, 2020

@iemejia Thanks for the tips and taking the time to help me out!

I ran spotlessApply, for some reason I forgot to do it 😊.
The commit title now includes the ticket [BEAM-10066].

Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I will merge manually to do some minor final touches).

Thanks for this one @naipath and don't hesitate to bring another PR also for the other configuration parameters in RedisIO.

@iemejia iemejia changed the title [BEAM-10066] Added support for ValueProvider in RedisConnectionConfiguration [BEAM-10066] Add support for ValueProviders in RedisConnectionConfiguration Jun 7, 2020
iemejia added a commit that referenced this pull request Jun 7, 2020
@iemejia
Copy link
Member

iemejia commented Jun 7, 2020

Merged manually.

@iemejia iemejia closed this Jun 7, 2020
@naipath naipath deleted the BEAM-10066-redis-valueprovider-support branch June 8, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants