[BEAM-10015] Fix output timestamp on dataflow runner #11725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 14, 2020 14:16
|
run dataflow validatesrunner |
reuvenlax
changed the title
|
run dataflow validatesrunner |
|
LGTM. Thanks for taking care of it. |
yirutang
pushed a commit
to yirutang/beam
that referenced
this pull request
Jul 23, 2020
… dataflow runner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is fixed by encoding the output timestamp in the timer tag so that we can recover it when firing the timer.
We also remove the old TimerData.of builders, as their accidental use caused the original bug.