Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-9767]: Fix flaky streaming wordcount #11663

Merged
merged 1 commit into from
May 11, 2020

Conversation

rohdesamuel
Copy link
Contributor

@rohdesamuel rohdesamuel commented May 11, 2020

The BackgroundCachingJob condition checker was failing due to a data race where the StreamingCache was created and read from before there was any data. This raised an uncaught StopIteration exception and failed the condition checker.

Also increases the timeout to 60s. On my local machine I reproed it by executing:

for i in {1..100}; do python interactive_runner_test.py InteractiveRunnerTest.test_streaming_wordcount 2>&1 | tee test_logs/$i & done

Which took a max of 60s.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

The BackgroundCachingJob condition checker was failing due to a data race where the StreamingCache was created and read from before there was any data. This raised an uncaught StopIteration exception and failed the condition checker.

Change-Id: Iecf47ec35dbf3c77881f8d59d77a872b41e11d3a
@rohdesamuel rohdesamuel changed the title Fix flaky streaming [BEAM-9767]: Fix flaky streaming wordcount May 11, 2020
@rohdesamuel rohdesamuel marked this pull request as ready for review May 11, 2020 18:18
@rohdesamuel
Copy link
Contributor Author

R: @pabloem

@pabloem
Copy link
Member

pabloem commented May 11, 2020

retest this please

@rohdesamuel
Copy link
Contributor Author

Run Python2_PVR_Flink PreCommit

1 similar comment
@pabloem
Copy link
Member

pabloem commented May 11, 2020

Run Python2_PVR_Flink PreCommit

@pabloem
Copy link
Member

pabloem commented May 11, 2020

LGTM

@pabloem pabloem merged commit 5d33f9c into apache:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants