[BEAM-9886] Auto-inferring project for ReadFromBigQuery #11560
Conversation
|
Run Portable_Python PreCommit |
|
Run Python 3.7 PostCommit |
|
Run Python 3.7 PostCommit |
|
py37 postcommit: https://builds.apache.org/job/beam_PostCommit_Python37_PR/128/ |
|
Run Python PreCommit |
|
Run Python 3.7 PostCommit |
|
Run Python 3.7 PostCommit |
|
Run Python2_PVR_Flink PreCommit |
|
PAssing precommit: https://builds.apache.org/job/beam_PostCommit_Python37_PR/132/ |
|
Run Python Precommit |
|
Run Python2_PVR_Flink PreCommit |
1 similar comment
|
Run Python2_PVR_Flink PreCommit |
|
Python2_PVR_Flink tests are broken on master : / |
|
Run Python2_PVR_Flink PreCommit |
| @@ -526,7 +526,7 @@ def reader(self, test_bigquery_client=None): | |||
|
|
|||
|
|
|||
| def _to_bool(value): | |||
| return value == 'true' | |||
| return value | |||
There was a problem hiding this comment.
could you explain why this change is needed?
There was a problem hiding this comment.
the coder incorrectly expected boolean types to be encoded as strings. This is incorrect, as JSON supports boolean 'natively', like this: https://json-schema.org/understanding-json-schema/reference/boolean.html
There was a problem hiding this comment.
Do we need the _to_bool function then, would the bool casting suffice?
There was a problem hiding this comment.
ahhh what a great catch. thanks Yichi!
|
Run Python 3.7 PostCommit |
pabloem
changed the title
…ct for ReadFromBigQuery * Auto-inferring project for ReadFromBigQuery * Fixup * fixup * fixup * Formatter fixup * Fixup * fixformat * Fix coder issue * fixup * Fix lint * Fixup
r: @kamilwu @y1chi
This helps infer the project where we should execute export jobs / queries / create temp tables, etc
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.