All Python DirectRunners call setup/teardown on DoFns #11547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennknowles
reviewed
Apr 28, 2020
| @@ -874,6 +875,7 @@ def process_element(self, element): | |||
|
|
|||
| def finish_bundle(self): | |||
| self.runner.finish() | |||
| self.runner.teardown() | |||
There was a problem hiding this comment.
Does the runner re-instantiate the DoFn for each bundle? That is the contract of teardown. The DoFn instance can never be touched again. (I'm mostly trying to learn more about the Python SDK and runners)
There was a problem hiding this comment.
Yes, it does re-instantiate for each bundle. I remember we had a jira somewhere to re-use dofn instances for more than one bundle, we never implemented that.
There was a problem hiding this comment.
I need to check this, but in Python, generally, we do not reuse Dofns, so they're recreated for each bundle. Let me confirm..
aaltay
approved these changes
Apr 28, 2020
|
Run Python PreCommit |
2 similar comments
|
Run Python PreCommit |
|
Run Python PreCommit |
|
Do you know if this will fix https://issues.apache.org/jira/browse/BEAM-7885 ? |
|
Ah indeed it should fix that. I'll mark it as fixed.
…On Tue, Apr 28, 2020, 7:33 PM Ahmet Altay ***@***.***> wrote:
Do you know if this will fix
https://issues.apache.org/jira/browse/BEAM-7885 ?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#11547 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ5Z3GESQIPKYSS2DGDBNTRO6GY5ANCNFSM4MSOERIA>
.
|
bntnam
pushed a commit
to PolideaInternal/beam
that referenced
this pull request
May 5, 2020
* All DirectRunners call setup/teardown on DoFns * fix formatter
yirutang
pushed a commit
to yirutang/beam
that referenced
this pull request
Jul 23, 2020
* All DirectRunners call setup/teardown on DoFns * fix formatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.