[BEAM-9812] Fixing bug causing pipelines requiring temp tables to not work #11509
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Python 3.6 PostCommit |
Merged
4 tasks
chamikaramj
reviewed
Apr 23, 2020
| @@ -182,7 +182,10 @@ def parse_table_reference(table, dataset=None, project=None): | |||
| """ | |||
|
|
|||
| if isinstance(table, bigquery.TableReference): | |||
| return table | |||
| return bigquery.TableReference( | |||
There was a problem hiding this comment.
Probably update the spec above to mention that a new object will be returned ?
There was a problem hiding this comment.
Another option might be to create a new object at line 343 which might be cleaner
There was a problem hiding this comment.
Ah... ok.. I can do that second option
There was a problem hiding this comment.
on second thought, I think it's a better practice to avoid reusing objects, and create copies for clarity...
|
running 3.6 PC: https://builds.apache.org/job/beam_PostCommit_Python36_PR/62/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue occurs here: https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/bigquery_file_loads.py#L333-L346
In line 343, the
tableIdfor the job destination is replaced. Because parse_table_reference does not create a new object, the original object is overwritten, and thus copy jobs are issued from temp_table to temp_table instead of being issued from temp_table to final_table.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.