[BEAM-9767] Add a timeout to the TestStream GRPC and fix the Streaming cache timeout #11440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I33908eab8313a90829a2115029f87b7f2f454f1b
|
R: @pabloem |
|
retest this please |
|
Looks like an unrelated error in the RAT (go learning katas have a bad license) |
pabloem
reviewed
Apr 17, 2020
| except StopIteration: | ||
| return | ||
| except grpc.RpcError as e: | ||
| if e.code() == grpc.StatusCode.DEADLINE_EXCEEDED: |
There was a problem hiding this comment.
Have you tested this? I see that we're raising RuntimeError in streaming_cache.py, but here we're catching grpc.RpcError - is that as intended?
There was a problem hiding this comment.
Yes, this exception is specifically for GRPC timing out. Any runtime error on the server side gets caught by its exception handler (see test_stream_service.py)
|
thanks Sam! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I33908eab8313a90829a2115029f87b7f2f454f1b
The TestStream read from GRPC method didn't have a timeout and had the possibility of hanging indefinitely. This adds a 30s inactivity timeout. This also fixes the StreamingCache waiting for file timeout which didn't work.
This doesn't necessarily fix BEAM-9767 because it looks more like a problem interacting with the test environment. This will make it so that the test times out after 30s instead of 600s.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.