[BEAM-9651] Prevent StreamPool and stream initialization livelock #11364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce StreamPool synchronized block by excluding stream creation and requiring it for release. Some Dataflow pipelines were observing stuck get and release methods due to stuck stream creation waiting for the onReady callback. The DirectStreamObserver is modified to additionally pool isReady() to handle cases where blocked threads are blocking the onReady callback. Additionally as we would prefer to possibly OOM versus becoming permanently stuck we give up waiting for onReady after a minute.
|
LGTM |
|
Note that the tests never ran on this change. Please only merge on green. Only committers can start tests on PRs which can sometimes be missed because changes can look like they are merge ready. |
|
run dataflow validatesrunner |
|
@lukecwik my bad - I missed that the tests hadn't triggered. is it possible to trigger tests now, or do we need a new PR? |
|
They would run automatically as a cron PostCommit or you can manually launch them from the Jenkins UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce StreamPool synchronized block section to not include stream
creation which includes sending initial messages. Additionally remove it from being
required to release holds. Some pipelines were observing stuck get and
release methods on synchronization. This was due to a stuck stream
creation waiting for the onReady callback. This could possibly have
been due to the callback being queued behind other callbacks on
blocked grpc threads. This was addressed in the DirectStreamObserver
used for the fn api so we reuse it here.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.