Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional new Python Katas #11078

Merged
merged 11 commits into from
Mar 10, 2020
Merged

Conversation

henryken
Copy link
Contributor

@henryken henryken commented Mar 9, 2020

Additional new Python Katas:

  • WithKeys
  • Adding Timestamp
  • Fixed Time Window

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@henryken
Copy link
Contributor Author

henryken commented Mar 9, 2020

R: @pabloem

@pabloem
Copy link
Member

pabloem commented Mar 9, 2020

this is great. I skimmed the changes, and they look good to me. Thanks @henryken !

@pabloem
Copy link
Member

pabloem commented Mar 9, 2020

retest this please

@pabloem
Copy link
Member

pabloem commented Mar 9, 2020

oops it's complaining about some license headers: https://builds.apache.org/job/beam_PreCommit_RAT_Commit/15290/console

@henryken
Copy link
Contributor Author

retest this please

@henryken
Copy link
Contributor Author

Thanks for pointing it out. How can I retest this @pabloem?

@pabloem
Copy link
Member

pabloem commented Mar 10, 2020

retest this please

1 similar comment
@pabloem
Copy link
Member

pabloem commented Mar 10, 2020

retest this please

@pabloem pabloem merged commit 0259a20 into apache:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants