[BEAM-6428] Improve select performance with codegen #11025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run dataflow validatesrunner |
|
run sql postcommit |
added 2 commits
March 3, 2020 01:37
reuvenlax
force-pushed
the
select_bytebuddy
branch
from
ae09399
to
e2287be
Compare
|
run dataflow validatesrunner |
|
run sql postcommit |
|
run dataflow validatesrunner |
|
run sql postcommit |
reuvenlax
changed the title
alexvanboxel
reviewed
Mar 4, 2020
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/Select.java
Outdated
Show resolved
Hide resolved
|
Run Java PreCommit |
4 tasks
alexvanboxel
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema select functionality is currently very inefficient - it walks through the schema resolution on each element selected in order to figure out how to properly distribute the select. Select is used by the select transform, but it is also used by the Group, Join, and any conversion transforms.
This PR analyzes the select predicate (e.g. a.b[].c.*), and generates bytecode to perform the select. All the schema resolution code that previously was done per element is now done once in order to determine what bytecode to generate.