[BEAM-9569] disable coder inference for rows #10990
Conversation
| Schema rightSchema = rightRows.getSchema(); | ||
| if (!leftSchema.typesEqual(rightSchema)) { | ||
| throw new IllegalArgumentException( | ||
| "Can't intersect two tables with different schemas." |
There was a problem hiding this comment.
This is the base class, so shouldn't be calling it "intersect". Incidentally I don't think having a base class adds much value here, so inlining or inverting would be a-ok.
| while (iter.hasNext()) { | ||
| ctx.output(iter.next()); | ||
| for (int i = 0; i < numLeftRows + numRightRows; i++) { | ||
| o.output(key); |
There was a problem hiding this comment.
This optimization seems to have nothing to do with disabling coder inference. Please split into separate commit so git history shows it.
|
@kennknowles I've removed the premature optimization. I decided to leave the base class for now - would prefer to leave that as a refactoring cleanup for another PR. Note: support for nullable fields in this PR (as this PR exposed bugs in the Schema transforms) is also pulled out into pr/11046. I plan on merging 11046 first and rebasing this one on top, so those changes will not be included in this merge. |
f80aca6
to
388ba36
Compare
|
@kennknowles the Select changes have now been rebased away |
|
R: @dpmills |
|
Run Java PreCommit |
|
LGTM |
No description provided.