[BEAM-9353] Fix bytebuddy nullable #10926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
alexvanboxel
approved these changes
Feb 24, 2020
There was a problem hiding this comment.
OK, I tried to understand it... but too be truthful this is something I need to gain some hands-on experience with (it's certainly a useful skillset to gain).
So, I've confirmed that tests are added for the functionality.
LGTM, after squash commit and decent commit message.
7308841
to
b63bd59
Compare
|
Yes this fixed the bug thanx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes NullPointerExceptions thrown when a Row with null values is converted to a Java type. The ByteBuddy generated code now checks for null values and properly handles them by returning null.
R: @rezarokni
R: @alexvanboxel