Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM=6857] Fix timermap test to not use TestStream #10622

Merged
merged 5 commits into from
Jan 18, 2020
Merged

[BEAM=6857] Fix timermap test to not use TestStream #10622

merged 5 commits into from
Jan 18, 2020

Conversation

reuvenlax
Copy link
Contributor

@reuvenlax reuvenlax commented Jan 17, 2020 •
edited
Loading

Since various runners exclude TestStream, this provides better test coverage.

@reuvenlax
Copy link
Contributor Author

Run Dataflow ValidatesRunner

@reuvenlax
Copy link
Contributor Author

run Flink ValidatesRunner

@reuvenlax
Copy link
Contributor Author

Run Spark ValidatesRunner

@reuvenlax
Copy link
Contributor Author

Run Samza ValidatesRunner

@reuvenlax
Copy link
Contributor Author

Run Apex ValidatesRunner

@reuvenlax reuvenlax changed the title Fix timermap test [BEAM=6857] Fix timermap test to not use TestStream Jan 17, 2020
@reuvenlax
Copy link
Contributor Author

R: @dpmills

@dpmills
Copy link
Contributor

dpmills commented Jan 17, 2020

LGTM

@reuvenlax
Copy link
Contributor Author

Run JavaPortabilityApi PreCommit

@reuvenlax reuvenlax merged commit ebe8bdc into apache:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reuvenlax @dpmills