Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-8955] Attach values so we don't iterate over everything to verify types #10362

Merged
merged 1 commit into from
Dec 12, 2019
Merged

[BEAM-8955] Attach values so we don't iterate over everything to verify types #10362

merged 1 commit into from
Dec 12, 2019

Conversation

reuvenlax
Copy link
Contributor

We were accidentally overiterating the result of a Group. This is problematic for the Spark runner and inefficient in general.

@reuvenlax
Copy link
Contributor Author

R: @suztomo

@suztomo
Copy link
Contributor

suztomo commented Dec 12, 2019

Run Spark ValidatesRunner

suztomo
suztomo approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for quick turnaround.

@reuvenlax reuvenlax merged commit b0c1d8c into apache:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

@TheNeuralBit TheNeuralBit Awaiting requested review from TheNeuralBit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reuvenlax @suztomo