[BEAM-7274] Support recursive type transformation in ByteBuddyUtils #10278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuvenlax
force-pushed
the
bytebuddy_recursive_types
branch
from
d97e213
to
2d1bcc0
Compare
reuvenlax
changed the title
alexvanboxel
reviewed
Dec 5, 2019
|
|
||
| /** A set of reflection helper methods. */ | ||
| public class ReflectUtils { | ||
| static class ClassWithSchema { | ||
| /** Represents a class and a schema. */ | ||
| public static class ClassWithSchema { |
There was a problem hiding this comment.
I assume it has a reason that they are now public? (was package protected)
There was a problem hiding this comment.
It's actually public because we need to use this in the protobuf schema provider which is in a different package (and in general, you should be able to put schema providers in other packages).
|
In general this LGTM. I see optimizations for the List vs Collection as List will be the most common use case. If I remember correctly the instanceof has minimal impact. |
added 2 commits
December 5, 2019 12:28
|
run sql postcommit |
11moon11
pushed a commit
to 11moon11/beam
that referenced
this pull request
Dec 12, 2019
…ransformation in ByteBuddyUtils
dpcollins-google
pushed a commit
to dpcollins-google/beam
that referenced
this pull request
Dec 20, 2019
…ransformation in ByteBuddyUtils
JozoVilcek
pushed a commit
to JozoVilcek/beam
that referenced
this pull request
Feb 21, 2020
…ransformation in ByteBuddyUtils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was uncovered by the attempt to add protocol buffer support to schemas. This PR refactors the schema utils to convert parameter types (e.g. for List to convert T as well). As part of this PR, Row now represents ARRAY types as a Collection instead of as a List.
R: @alexvanboxel