[BEAM-8869] Exclude system metrics test from legacy runner test suite #10266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Flink ValidatesRunner |
|
R: @kennknowles Thanks for pointing out the failing test. I fixed it, can you take a look? |
|
Run Flink ValidatesRunner |
kennknowles
approved these changes
Dec 4, 2019
| ValidatesRunner.class, | ||
| UsesAttemptedMetrics.class, | ||
| UsesCounterMetrics.class, | ||
| UsesSystemMetrics.class |
There was a problem hiding this comment.
Just to double check since I don't really know what all the categories mean - is it possible that UsesMetricsPusher is relevant?
There was a problem hiding this comment.
I don't think so - MetricsPusher is used in both portable and legacy modes of runners.
(eg. in FlinkRunner )
The issue here is that legacy Flink runner doesn't expose system metrics, so the test involving them made the whole suite fail.
mxm
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since system metrics aren't available in legacy runners, I disabled them for legacy Flink test suite.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.