Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup of tests using TestStream. #10188

Merged
merged 2 commits into from
Dec 20, 2019
Merged

Conversation

acrites
Copy link
Contributor

@acrites acrites commented Nov 21, 2019

  • Added advance_watermark_to_infinity() to end of TestStreams.
  • Updated test to not use in-memory state and instead use assert_that.
  • Added streaming = true to a pipeline test "in_streaming_mode" (is this even needed?).

R: @lukecwik


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is/was advance_to_infinity implied in some runners?

sdks/python/apache_beam/transforms/util_test.py Outdated Show resolved Hide resolved
@acrites
Copy link
Contributor Author

acrites commented Nov 26, 2019

Run Python PreCommit

1 similar comment
@acrites
Copy link
Contributor Author

acrites commented Dec 2, 2019

Run Python PreCommit

@lukecwik
Copy link
Member

lukecwik commented Dec 2, 2019

Run Python PreCommit

@lukecwik
Copy link
Member

lukecwik commented Dec 2, 2019

It could be that your changes are making tests get stuck which causes the jenkins run to timeout. I have seen this with some of my changes in the past.

@acrites
Copy link
Contributor Author

acrites commented Dec 2, 2019

I see these two failures:

11:05:50 Execution failed for task ':sdks:python:test-suites:tox:py37:testPy37Cython'.
11:05:50 > Could not copy file '/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase@2/src/sdks/python/.eggs/timeloop-1.0.2-py3.7.egg' to '/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase@2/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/.eggs/timeloop-1.0.2-py3.7.egg'.

11:05:50 Execution failed for task ':sdks:python:test-suites:tox:py2:testPy2Cython'.
11:05:50 > Could not copy file '/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase@2/src/sdks/python/.eggs/simplegeneric-0.8.1-py2.7.egg' to '/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Phrase@2/src/sdks/python/test-suites/tox/py2/build/srcs/sdks/python/.eggs/simplegeneric-0.8.1-py2.7.egg'.

I looked through all the logs and I think all the stack traces showing were caused by tests that are supposed to fail.

@lukecwik
Copy link
Member

lukecwik commented Dec 2, 2019 via email

@acrites acrites requested a review from robertwb December 4, 2019 19:15
@lukecwik lukecwik merged commit b06fb9d into apache:master Dec 20, 2019
vmarquez pushed a commit to vmarquez/beam that referenced this pull request Apr 1, 2020
* Minor cleanup of tests using TestStream. Added advance_watermark_to_infinity to end of TestStream.

* Combines multiple lines into one.
@acrites acrites deleted the test-stream branch April 7, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants