Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVRO-2299 Normalize Avro Standard Canonical Schema. #452

Closed
wants to merge 24 commits into from
Closed

AVRO-2299 Normalize Avro Standard Canonical Schema. #452

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
a86cd25
AVRO-2299 Get Avro Standard Canonical Schema.
Feb 11, 2019
04c00d2
AVRO-2299 Get Avro Standard Canonical Schema.
Feb 11, 2019
f77b84b
Merge remote-tracking branch 'origin/master'
Mar 14, 2019
c5e6985
AVRO-2299 test cases fixed with new aliases order expected output.
Mar 14, 2019
bc8fa22
AVRO-2299 added the canonical form Doc in Specification.
Mar 15, 2019
1119b6e
Multiple static analysis fixes and code modernization
iemejia Mar 12, 2019
8026c8f
AVRO-2353: Configure spotless-maven-plugin to auto format/validate Ja…
iemejia Mar 26, 2019
8f0eca6
AVRO-2356: Encoder Cannot Be Null
belugabehr Mar 22, 2019
d81bffd
AVRO-2355 [java] Add level and checksum options to ZStandard compression
scottcarey Mar 21, 2019
b2f4790
Cleanup poms a bit
dkulp Mar 28, 2019
ff6a4e8
Change default from joda to jsr310... no sense promoting the use of j…
dkulp Mar 28, 2019
c1abf35
Change the default for generated fields to "private" so we aren't gen…
dkulp Mar 28, 2019
05ad1a7
[AVRO-2630] Part 1 - for JDR310, time-micros and timestamp-micros can…
dkulp Mar 28, 2019
48ed810
AVRO-2346: Introduce JMH Performance Testing Framework
belugabehr Mar 7, 2019
8197803
[AVRO-2630] Part 2 - allow the JSR310 conversions to truncate at the …
dkulp Mar 28, 2019
c552c17
AVRO-2336: Use Java Standard Charsets - Part 2
belugabehr Mar 28, 2019
c369dd1
Rename JSR310 conversion class to TimeConversions, deprecate Joda con…
nandorKollar Mar 29, 2019
db992cf
AVRO-2362: Enable calling mvn spotless:apply to auto format code
iemejia Mar 28, 2019
5143fe2
AVRO-2299 Get Avro Standard Canonical Schema.
Feb 11, 2019
74572fb
AVRO-2299 Get Avro Standard Canonical Schema.
Feb 11, 2019
f15934a
AVRO-2299 test cases fixed with new aliases order expected output.
Mar 14, 2019
1ab972b
AVRO-2299 added the canonical form Doc in Specification.
Mar 15, 2019
b16e622
AVRO-2299 Code Style using spotless.
Mar 31, 2019
71ab06c
Merge remote-tracking branch 'origin/master'
Mar 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
AVRO-2299 test cases fixed with new aliases order expected output.
  • Loading branch information
rumeshkrishnan committed Mar 31, 2019
commit f15934acf5cde1ac4bfe09dd4d59881212b308f1
4 changes: 2 additions & 2 deletions lang/java/avro/src/test/java/org/apache/avro/TestSchemaNormalization.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public static class TestStandardCanonicalSchema {
{ return CaseFinder.find(data(STANDARD_CANONICAL_DATA_FILE), "canonical", new ArrayList<>()); }

@Test public void testCanonicalization() throws Exception {
assertEquals(SchemaNormalization.toCanonicalForm(Schema.parse(input)),
assertEquals(SchemaNormalization.toCanonicalForm(new Schema.Parser().parse(input)),
expectedOutput);
}
}
Expand All @@ -98,7 +98,7 @@ public static class TestCustomCanonicalSchema {
{ return CaseFinder.find(data(CUSTOM_CANONICAL_DATA_FILE), "canonical", new ArrayList<>()); }

@Test public void testCanonicalization() throws Exception {
assertEquals(SchemaNormalization.toCanonicalForm(Schema.parse(input), properties),
assertEquals(SchemaNormalization.toCanonicalForm(new Schema.Parser().parse(input), properties),
expectedOutput);
}
}
Expand Down
4 changes: 2 additions & 2 deletions share/test/data/standard-schema-tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,11 @@

// 023
<<INPUT {"fields":[], "type":"record", "name":"foo", "aliases":["foo","bar"]}
<<canonical {"name":"foo","type":"record","fields":[],"aliases":["foo","bar"]}
<<canonical {"name":"foo","type":"record","fields":[],"aliases":["bar","foo"]}

// 024
<<INPUT {"fields":[], "type":"record", "name":"foo", "doc":"foo", "aliases":["foo","bar"]}
<<canonical {"name":"foo","type":"record","fields":[],"doc":"foo","aliases":["foo","bar"]}
<<canonical {"name":"foo","type":"record","fields":[],"doc":"foo","aliases":["bar","foo"]}

// 025
<<INPUT {"fields":[{"type":{"type":"boolean"}, "name":"f1"}], "type":"record", "name":"foo"}
Expand Down