Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3088: use modern CMake style with config file #1150

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mitjap
Copy link
Contributor

@mitjap mitjap commented Mar 22, 2021

I'm proposing some changes to CMake that would also install config file which makes it easier for downstream libraries to use avro as dependency.

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@github-actions github-actions bot added the C++ Pull Requests for C++ binding label Mar 22, 2021
@mitjap
Copy link
Contributor Author

mitjap commented Mar 22, 2021

This PR does two things, it uses more modern CMake with targets and better manages dependencies between targets and add installation of config files. Do you think this shuld be two separate PRs?

@mkmkme
Copy link
Contributor

mkmkme commented Feb 17, 2024

Hey @mitjap !

Are you still interested in getting this finalized?

@mitjap
Copy link
Contributor Author

mitjap commented Feb 17, 2024

If I remember correctly this is it. I was waiting for a feedback before removing a draft label.

@mkmkme
Copy link
Contributor

mkmkme commented Feb 17, 2024

Okay, thanks!
I'll take a closer look as soon as possible.

If you could rebase it on the top of current main, it would be great.

@mkmkme
Copy link
Contributor

mkmkme commented Feb 17, 2024

Also if you could split it into two PRs as you suggested above, it would be much easier to review!

If you don't have time for doing this, let me know and I can do this myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Pull Requests for C++ binding
Projects
None yet
2 participants