Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: fixup contribution guide about clippy #5952

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 24, 2024

Which issue does this PR close?

N/A

Rationale for this change

While working on #5907 I ran into this ancient piece of advice that is not accurate anymore

What changes are included in this PR?

Update to contributing guide to reflect the current state with clippy

Are there any user-facing changes?


Run the following to check for `clippy` lints:

```bash
# run clippy with default settings
cargo clippy
cargo clippy --workspace --all-targets --all-features -- -D warnings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work on my archlinux x86_64:

error: sub-expression diverges
   --> arrow-flight/tests/flight_sql_client_cli.rs:657:9
    |
657 |         unimplemented!("Implement do_action_end_savepoint")
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
    = note: this error originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

error: sub-expression diverges
   --> arrow-flight/tests/flight_sql_client_cli.rs:665:9
    |
665 |         unimplemented!("Implement do_action_cancel_query")
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
    = note: this error originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `unimplemented` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not compile `arrow-flight` (test "flight_sql_client_cli") due to 7 previous errors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like it may be due to the fact you are using nightly rust by default

does it work with:

cargo +stable clippy --workspace --all-targets --all-features -- -D warnings

@tustvold tustvold merged commit 901fbe8 into apache:master Jun 25, 2024
9 checks passed
@alamb alamb added the development-process Related to development process of arrow-rs label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants