Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark for casting view to dict arrays (and the reverse) #5874

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

XiangpengHao
Copy link
Contributor

@XiangpengHao XiangpengHao commented Jun 12, 2024

Which issue does this PR close?

Part of #5861 .

Rationale for this change

Setup a benchmark and see what the performance look like for casting between view and dict arrays.

Related: #5871 #5872

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 12, 2024
alamb
alamb previously approved these changes Jun 12, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XiangpengHao -- can you please add this benchmark to the existing cast kernel benchmarks rather than its own bench: https://github.com/apache/arrow-rs/blob/master/arrow/benches/cast_kernels.rs ?

(🤔 maybe we should move that cast_kernels.rs benchmark to arrow-cast/benchmarks )

@alamb alamb dismissed their stale review June 12, 2024 19:52

clicked wrong button

@XiangpengHao
Copy link
Contributor Author

Thanks @XiangpengHao -- can you please add this benchmark to the existing cast kernel benchmarks rather than its own bench: https://github.com/apache/arrow-rs/blob/master/arrow/benches/cast_kernels.rs ?

(🤔 maybe we should move that cast_kernels.rs benchmark to arrow-cast/benchmarks )

Done.

The cast_kernel.rs can't be moved to arrow-cast/benches because it depends create_primitive_array and seedable_rng which are currently in arrow directory.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XiangpengHao

@alamb
Copy link
Contributor

alamb commented Jun 12, 2024

🚀

Merging this in so we can compare performace of main to the specialized cast kernels

@alamb alamb merged commit 4fc9ad1 into apache:master Jun 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants