Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of casting StringView/BinaryView to DictionaryArray #5872

Merged
merged 10 commits into from
Jun 13, 2024
Merged

Improve performance of casting StringView/BinaryView to DictionaryArray #5872

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
63db275
zero-copy dict to view
XiangpengHao Jun 11, 2024
bc626fe
view to dict
XiangpengHao Jun 11, 2024
0308dd4
refactor to use try_append_view
XiangpengHao Jun 11, 2024
c27d548
unchecked view
XiangpengHao Jun 11, 2024
8978134
Merge branch 'view-to-dict' into dict-to-view
XiangpengHao Jun 11, 2024
fdebc0e
make fmt happy
XiangpengHao Jun 11, 2024
c951711
Merge branch 'view-to-dict' into dict-to-view
XiangpengHao Jun 11, 2024
cd8457e
update test
XiangpengHao Jun 11, 2024
9331077
add comments
XiangpengHao Jun 11, 2024
89d0b98
Merge remote-tracking branch 'apache/master' into dict-to-view
alamb Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update test
  • Loading branch information
@XiangpengHao
XiangpengHao committed Jun 11, 2024
commit cd8457e20df0403d5ccb0f57396b097f0c1e1429
16 changes: 4 additions & 12 deletions arrow-cast/src/cast/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5205,10 +5205,10 @@ mod tests {

const VIEW_TEST_DATA: [Option<&str>; 5] = [
Some("hello"),
Some("world"),
Some("repeated"),
None,
Some("large payload over 12 bytes"),
Some("lulu"),
Some("repeated"),
];

fn _test_string_to_view<O>()
Expand Down Expand Up @@ -5350,23 +5350,15 @@ mod tests {
where
O: OffsetSizeTrait,
{
let data: Vec<Option<&[u8]>> = vec![
Some(b"hello"),
Some(b"world"),
None,
Some(b"large payload over 12 bytes"),
Some(b"lulu"),
];

let view_array = {
let mut builder = BinaryViewBuilder::new().with_block_size(8); // multiple buffers.
for s in data.iter() {
for s in VIEW_TEST_DATA.iter() {
builder.append_option(*s);
}
builder.finish()
};

let expected_binary_array = GenericBinaryArray::<O>::from(data);
let expected_binary_array = GenericBinaryArray::<O>::from_iter(VIEW_TEST_DATA);
let expected_type = expected_binary_array.data_type();

assert!(can_cast_types(view_array.data_type(), expected_type));
Expand Down