Fix 'ColumnPath not found' error reading Parquet files with nested REPEATED fields #5102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunchao
reviewed
Nov 28, 2023
| @@ -274,12 +274,12 @@ impl TreeBuilder { | |||
| row_group_reader, | |||
| )?; | |||
|
|
|||
| Reader::RepeatedReader( | |||
| return Ok(Reader::RepeatedReader( | |||
There was a problem hiding this comment.
nit: instead of returning early here we could also just remove the path.pop() above
There was a problem hiding this comment.
Will that not change the path passed to reader_tree above? Does that not matter?
There was a problem hiding this comment.
I tried removing path.pop() early on and the recursive call to reader_tree() started failing because it did not find the fields it expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5064.
Rationale for this change
reader_tree()maintains a stack of field names as it recurses through nested schemas. When it encounters aREPEATEDfield, it performs two pops for only one push and ends up being off by one. The change ensures the counts of pushes and pops match.Are there any user-facing changes?
No