Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(parquet): use optimized bloom filter #4441

Closed
wants to merge 9 commits into from
Closed

perf(parquet): use optimized bloom filter #4441

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e0d059f
use optimized bloom filter
ozgrakkurt Jun 21, 2023
410f4be
bump dep
ozgrakkurt Jun 21, 2023
f590304
run fmt
ozgrakkurt Jun 22, 2023
0a8a601
don't do extra copy
ozgrakkurt Jun 28, 2023
c98ec16
remove Sbbf::new
ozgrakkurt Jun 28, 2023
003c2c4
update test
ozgrakkurt Jun 28, 2023
d5fca99
bump
ozgrakkurt Jun 30, 2023
106511a
feature gate
ozgrakkurt Jul 1, 2023
fe1c679
fix doc errors
ozgrakkurt Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix doc errors
  • Loading branch information
@ozgrakkurt
ozgrakkurt committed Jul 3, 2023
commit fe1c67956377098cf9aa582333762e11306da47c
2 changes: 1 addition & 1 deletion parquet/src/bloom_filter/default.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ impl Sbbf {
}

/// Create a new [Sbbf] with given number of bytes, the exact number of bytes will be adjusted
/// to the next power of two bounded by [BITSET_MIN_LENGTH] and [BITSET_MAX_LENGTH].
/// to the next power of two bounded by [super::BITSET_MIN_LENGTH] and [super::BITSET_MAX_LENGTH].
pub(crate) fn new_with_num_of_bytes(num_bytes: usize) -> Self {
let num_bytes = optimal_num_of_bytes(num_bytes);
let bitset = vec![0_u8; num_bytes];
Expand Down
2 changes: 1 addition & 1 deletion parquet/src/bloom_filter/fast.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ impl Sbbf {
}

/// Create a new [Sbbf] with given number of bytes, the exact number of bytes will be adjusted
/// to the next power of two bounded by [BITSET_MIN_LENGTH] and [BITSET_MAX_LENGTH].
/// to the next power of two bounded by [super::BITSET_MIN_LENGTH] and [super::BITSET_MAX_LENGTH].
pub(crate) fn new_with_num_of_bytes(num_bytes: usize) -> Self {
let num_bytes = optimal_num_of_bytes(num_bytes);
Self(Filter::new(8, num_bytes))
Expand Down