Split object_store into separate workspace #4036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Apr 7, 2023
| sed -i -e 's/\(^object_store.*\)\(path = ".*", \)/\1/g' parquet/Cargo.toml | ||
| (cd parquet && cargo build && cargo test) | ||
| (cd parquet_derive && cargo build && cargo test) | ||
| cargo test --all |
There was a problem hiding this comment.
As an added bonus this is a more thorough verification, as it will run the tests for the child crates
There was a problem hiding this comment.
I do wonder if we should be passing more features to this, but this is strictly better than it was before
tustvold
commented
Apr 7, 2023
| mkdir -p ${distdir} | ||
| (cd "${SOURCE_TOP_DIR}" && \ | ||
| git archive ${release_hash} --prefix ${release}/ \ | ||
| | $tar --delete ${release}/'object_store' \ | ||
| | $tar --delete ${release}/'Cargo.toml' \ |
There was a problem hiding this comment.
Following #3936 this causes issues, as it removes the workspace from which the properties are derived
tustvold
commented
Apr 7, 2023
| @@ -43,7 +43,8 @@ arrow-data = { workspace = true, optional = true } | |||
| arrow-schema = { workspace = true, optional = true } | |||
| arrow-select = { workspace = true, optional = true } | |||
| arrow-ipc = { workspace = true, optional = true } | |||
| object_store = { version = "0.5", path = "../object_store", default-features = false, optional = true } | |||
| # Intentionally not a path dependency as object_store is released separately | |||
| object_store = { version = "0.5", default-features = false, optional = true } | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relates to #4030
Closes #3414
Rationale for this change
object_storefollows a separate release cycle and is distributed independently, having it in the same workspace creates friction and requires workarounds that then cause their own issues. Simpler to just keep it separate.What changes are included in this PR?
Splits object_store into its own workspace
Are there any user-facing changes?