Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generify parquet write path (#1764) #2045

Merged
merged 8 commits into from
Jul 17, 2022
Merged

Generify parquet write path (#1764) #2045

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aa72844
Generify parquet write path (#1764)
tustvold Jul 6, 2022
64e62c5
More docs
tustvold Jul 11, 2022
680bb77
Lint
tustvold Jul 12, 2022
2f961f2
Fix doc
tustvold Jul 12, 2022
42cca6b
Review feedback
tustvold Jul 16, 2022
1775f8f
Merge remote-tracking branch 'upstream/master' into generify-write-path
tustvold Jul 16, 2022
7df5199
Merge remote-tracking branch 'upstream/master' into generify-write-path
tustvold Jul 17, 2022
496bb70
Fix doc
tustvold Jul 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/master' into generify-write-path
  • Loading branch information
@tustvold
tustvold committed Jul 16, 2022
commit 1775f8f8070ef9b7203de463b7c822a458700c34
2 changes: 0 additions & 2 deletions parquet/src/column/writer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,6 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a, E> {
rep_levels: Option<&[i16]>,
min: Option<&E::T>,
max: Option<&E::T>,
null_count: Option<u64>,
distinct_count: Option<u64>,
) -> Result<usize> {
// We check for DataPage limits only after we have inserted the values. If a user
Expand Down Expand Up @@ -366,7 +365,6 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a, E> {
rep_levels: Option<&[i16]>,
min: Option<&E::T>,
max: Option<&E::T>,
nulls_count: Option<u64>,
distinct_count: Option<u64>,
) -> Result<usize> {
self.write_batch_internal(
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.