Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Lint and format amoro web code before commit #3248

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

chouchouji
Copy link
Contributor

Background

I found that the web project contains some code with lint errors and formatting issues many times.

I add two packages to lint and format code before commit. It is helpful to improve code quality and keep unified coding style.

Result

20241012-202344

20241012-202507

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Oct 12, 2024
@chouchouji chouchouji force-pushed the format-code branch 2 times, most recently from e49a73e to e10c7b9 Compare October 12, 2024 13:27
Copy link
Contributor

@czy006 czy006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after I saw it have 2 errors, can we fix it?

@chouchouji
Copy link
Contributor Author

after I saw it have 2 errors, can we fix it?

Yes. If you want to commit successfully, all errors should be fixed.

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the work to improve code quality.

@zhoujinsong zhoujinsong merged commit 869b5d9 into apache:master Oct 14, 2024
1 check passed
@chouchouji chouchouji deleted the format-code branch October 14, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants