Upgrade to weaviate-client to v4 #40194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
force-pushed
the
upgrade-to-weaviate-v4
branch
10 times, most recently
from
12f8cca
to
2b594c8
Compare
Lee-W
force-pushed
the
upgrade-to-weaviate-v4
branch
from
d83cb31
to
9b83e63
Compare
|
Hi @eladkal , if my memory serves me right, when we make a PR with breaking changes to a provider, we need to mark it somewhere. Could you please point out where I should mark it? Thanks! |
Lee-W
force-pushed
the
upgrade-to-weaviate-v4
branch
from
8dc6b31
to
de8b78c
Compare
In provider's CHANGELOG.rst (see comment at the top of it). But is it really a breaking change for the users of the Hook/Operator? |
|
Looked at it - there are many changes and it does look like breaking looking at the few of those. In CHANGELOG you should describe what the users of previous version should do to migrate to this one. |
Lee-W
force-pushed
the
upgrade-to-weaviate-v4
branch
from
de8b78c
to
8db59a4
Compare
phanikumv
requested review from
vatsrahul1001,
utkarsharma2,
Taragolis,
pankajastro,
pankajkoti and
sunank200
Lee-W
force-pushed
the
upgrade-to-weaviate-v4
branch
4 times, most recently
from
d47fd91
to
54c1b7b
Compare
…as there's no v4 API counterpart
… no v4 API counterpart
…perties_to_dict, check_subset_of_schema as there's no v4 API counterpart
…n_configuration for consistency
Lee-W
force-pushed
the
upgrade-to-weaviate-v4
branch
from
176b60d
to
8f6f4ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
According to Weaviate Python client (v4) goes GA, the v3 client is now deprecated and we need to upgrade to v4
What
test_connectionscreate_classtocreate_collectionget_schematoget_collection_configuraitondelete_classestodelete_collectionsquery_with_vectorquery_without_vectortoquery_with_textcreate_objectget_objectdelete_objectupdate_objectreplace_objectobject_existsbatch_dataget_or_create_objectupdate_collection_configuration_generate_uuidscreate_or_replace_document_objects_delete_objects_delete_all_documents_objects_get_documents_to_uuid_map_get_segregated_documentsvalidate_objectupdate_schemacreate_schemadelete_all_schemacreate_or_replace_classes_compare_schema_subset_convert_properties_to_dictcheck_subset_of_schemaget_client__init__WeaviateDocumentIngestOperatorandWeaviateIngestOperatorto use hook with v4 API^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.