-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow FTPHook to change port number #39465
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on your first PR.
Can you add the test case for custom port?
Yes, I'll do the test case over the weekend. |
I did some tests and fixed a tiny bug, when no port is supplied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @VelmiraPetkova
LGTM +1
@VelmiraPetkova can you please fix static checks? |
Sorry for the delay. I updated the PR. Could you please take a look? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @VelmiraPetkova!
@dirrao wdyt?
The failing integration test case is a flake - mssql does not have enough time to start. This has been fixed in #39866 |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* Allow FTPHook to change port * Add integration tests and fix a bug * Styling fix * Add logging of the FTP host and port * Update logging and test styling * styling fix * formatting change * Update airflow/providers/ftp/hooks/ftp.py * fix log statement formatting --------- Co-authored-by: Elad Kalif <[email protected]>
* Allow FTPHook to change port * Add integration tests and fix a bug * Styling fix * Add logging of the FTP host and port * Update logging and test styling * styling fix * formatting change * Update airflow/providers/ftp/hooks/ftp.py * fix log statement formatting --------- Co-authored-by: Elad Kalif <[email protected]>
* Allow FTPHook to change port * Add integration tests and fix a bug * Styling fix * Add logging of the FTP host and port * Update logging and test styling * styling fix * formatting change * Update airflow/providers/ftp/hooks/ftp.py * fix log statement formatting --------- Co-authored-by: Elad Kalif <[email protected]>
Allow FTPHook to use a custom FTP port number
closes: #39308